Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes add-on install button #4635

Merged
merged 4 commits into from Jan 28, 2020
Merged

Fixes add-on install button #4635

merged 4 commits into from Jan 28, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jan 28, 2020

Proposed change

  • Use ha-progress-button and this._installing to control the progress spinner

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

For the most part yaml is not really needed here is it?

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

How? Why? Examples, please.

  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 7937714 into home-assistant:dev Jan 28, 2020
@bramkragten bramkragten mentioned this pull request Jan 29, 2020
@lock lock bot locked and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing add-on, not showing in progress indicator in button.
3 participants