Convert Hass.io add-on options to YAML #4717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Converts hassio add-on options to YAML. Show error if it's invalid.
Fixes #4622
@bramkragten I made some changes to ha-yaml-editor that we need to validate in other places:
setValue
on firstUpdated if it's defined. I ended up running into a race condition wherevalue
from parent was being overridden byfirstUpdated
. We should really rename this property todefaultValue
, because it's only used on initial initialization. It's not used after that.value-changed
if the value changed, even if it's invalid and so the value is actually not the same as the entered value. We read theisValid
option from the editor on value changed to be able to show an error.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: