Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add haptic events to addon info toggles. #4719

Merged
merged 1 commit into from Feb 1, 2020
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 1, 2020

Breaking change

Proposed change

Add haptic events to addon info toggles. The toggles are using ha-switch. I've added a new haptic attribute to <ha-switch> to opt-in to make it vibrate on changes. Only use this option if the new value of the toggle is applied/saved when it is changed. Do not add haptic to toggles that require a user to press save.

Fixes #3852

Screenshot

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob added the Supervisor Related to the supervisor panel label Feb 1, 2020
@balloob balloob merged commit b082828 into dev Feb 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the hassio-forward-haptic branch February 1, 2020 16:12
@lock lock bot locked and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hassio toggle switches missing haptic feedback
3 participants