Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敡 Standardize Generic Dialogs #4726

Merged
merged 8 commits into from
Mar 9, 2020
Merged

馃敡 Standardize Generic Dialogs #4726

merged 8 commits into from
Mar 9, 2020

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Feb 2, 2020 •
edited

Proposed change

Swaps some more dialogs to use the generic dialog added in #4114

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@timmo001 timmo001 changed the title 馃敡 Standardize Dialogs 馃敡 Standardize Generic Dialogs Feb 2, 2020
@timmo001 timmo001 marked this pull request as ready for review February 2, 2020 13:42
@balloob
Copy link
Member

balloob commented Feb 3, 2020

FYI: In #4718 I am converting our dialogs to be able to use them with await too.

image

@bramkragten bramkragten merged commit 52160a3 into home-assistant:dev Mar 9, 2020
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timmo001 @balloob @bramkragten @homeassistant