Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logbook] fix dropdown animation #4834

Merged
merged 1 commit into from Feb 11, 2020
Merged

Conversation

KapJI
Copy link
Member

@KapJI KapJI commented Feb 11, 2020

Proposed change

During the opening animation text in dropdown items is wrapped in 2 lines which causes animation glitch. Mark these caption with nowrap to prevent this.

ezgif-2-40ac1ecb0aa6

Bad frame from old animation:
Screen Shot 2020-02-11 at 12 41 02 AM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@balloob balloob merged commit 8cee5c7 into home-assistant:dev Feb 11, 2020
@bramkragten bramkragten mentioned this pull request Feb 12, 2020
@lock lock bot locked and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants