Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify YAML reloading config header #4835

Merged
merged 1 commit into from Feb 11, 2020
Merged

Clarify YAML reloading config header #4835

merged 1 commit into from Feb 11, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 11, 2020

Breaking change

Proposed change

So both person and zone would crash if you didn't have person/zones in your YAML and called the reload service. Both times it was reported by someone who did not use YAML to config either but somehow thought they had to call the reload functions.

This PR clarifies header/description. Suggestons on improvements for this welcome.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob changed the title Update en.json Clarify YAML reloading config header Feb 11, 2020
@bramkragten bramkragten merged commit d052b9e into dev Feb 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the clarify-reload branch February 11, 2020 08:05
@bramkragten bramkragten mentioned this pull request Feb 12, 2020
@lock lock bot locked and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants