Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert History Graph Card to Typescript #4882

Merged
merged 4 commits into from
Feb 19, 2020

Conversation

zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Feb 15, 2020

Proposed change

Converts History Graph Card to TypeScript. Also removes the need of the polymer data element and refreshes the cached history within the element its self

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

@zsarnett zsarnett changed the title History graph ts Convert History Graph Card to Typescript Feb 15, 2020
@iantrich
Copy link
Member

iantrich commented Feb 15, 2020

We should double check maybe, but I think this removes Polymer from Lovelace completely 🎉

@zsarnett
Copy link
Contributor Author

I was looking at that. It seems the Notification Drawer is in that list but it is still a Polymer Element but not within the Lovelace folder

@iantrich
Copy link
Member

I was looking at that. It seems the Notification Drawer is in that list but it is still a Polymer Element but not within the Lovelace folder

Yeah we moved it out of Lovelace awhile back, just checked it off the list 🎉 Polymer-free

@bramkragten bramkragten merged commit 4be1040 into home-assistant:dev Feb 19, 2020
@bramkragten bramkragten mentioned this pull request Feb 19, 2020
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants