Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logbook] fix scrolling on iOS #4950

Merged
merged 4 commits into from Feb 24, 2020
Merged

Conversation

KapJI
Copy link
Member

@KapJI KapJI commented Feb 20, 2020

Proposed change

Fix issue when you can scroll only one item at time on iOS/ipadOS.

My theory is that when you try to append element to shadow root the current scroll action is reset and new events are not fired before you start scrolling again. This doesn't happen when you append to normal element inside shadow root.

And this is what this change does. lit-virtualizer creates shadow root when scroll() doesn't. And to function properly we need to manually set styles which were added to shadow root before.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@KapJI
Copy link
Member Author

KapJI commented Feb 24, 2020

@bramkragten do you mind merging this one as well?

@bramkragten bramkragten merged commit 028b370 into home-assistant:dev Feb 24, 2020
@WilldabeastHA
Copy link

Thanks for fixing this! What’s the best way to update this fix on my Home Assistant Core?

@KapJI
Copy link
Member Author

KapJI commented Feb 24, 2020

@WilldabeastHA If you want it today then follow these instructions to use development version: https://developers.home-assistant.io/docs/frontend_development/
Or just wait before the next version is released.

@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants