Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Picker with Previews of cards #4975

Merged
merged 26 commits into from Mar 3, 2020
Merged

Conversation

zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Feb 25, 2020

Proposed change

Add a preview to the Card Picker so the user knows what the card looks like before choosing. Pull from unused entities first, fall back to used entities. Scaling cards down to 60% of full size to fit better into the dialog. Using card config array instead of the string array of cards before.

Screenshot from Gyazo
image
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • Update src/translations/en.json with new phrases

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

@zsarnett
Copy link
Contributor Author

Not sure if its helpful to review my self but :). Just places I could see comments happening or had questions on.

@bramkragten
Copy link
Member

Layout wise, I'm not a fan of the cards in cards, can we make it just a rounded border instead of a card?

@bramkragten
Copy link
Member

We should also check if entities are available before adding them to the preview.

@zsarnett
Copy link
Contributor Author

zsarnett commented Feb 27, 2020

  • Updated Original post with new style updates
  • ToDo:
    • Filter out non-numeric/whatever the card doesn't like (Guage - Non-numeric)
    • If the card comes back as an error card, remove it from preview list, add to non-preview list

@zsarnett zsarnett merged commit aa2e632 into home-assistant:dev Mar 3, 2020
@zsarnett zsarnett deleted the card-picker branch March 3, 2020 20:08
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants