New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card Picker with Previews of cards #4975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsarnett
commented
Feb 25, 2020
zsarnett
commented
Feb 25, 2020
zsarnett
commented
Feb 25, 2020
zsarnett
commented
Feb 25, 2020
zsarnett
commented
Feb 25, 2020
zsarnett
commented
Feb 25, 2020
zsarnett
commented
Feb 25, 2020
Not sure if its helpful to review my self but :). Just places I could see comments happening or had questions on. |
bramkragten
reviewed
Feb 26, 2020
bramkragten
reviewed
Feb 26, 2020
bramkragten
reviewed
Feb 26, 2020
bramkragten
reviewed
Feb 26, 2020
bramkragten
reviewed
Feb 26, 2020
bramkragten
reviewed
Feb 26, 2020
Layout wise, I'm not a fan of the cards in cards, can we make it just a rounded border instead of a card? |
We should also check if entities are available before adding them to the preview. |
|
zsarnett
force-pushed
the
card-picker
branch
from
February 27, 2020 16:46
5b0f3a5
to
cfbb9f2
Compare
zsarnett
commented
Feb 27, 2020
bramkragten
reviewed
Feb 28, 2020
bramkragten
reviewed
Feb 28, 2020
bramkragten
reviewed
Feb 28, 2020
bramkragten
reviewed
Feb 28, 2020
bramkragten
reviewed
Feb 28, 2020
bramkragten
reviewed
Feb 28, 2020
zsarnett
commented
Feb 29, 2020
bramkragten
reviewed
Mar 3, 2020
bramkragten
approved these changes
Mar 3, 2020
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a preview to the Card Picker so the user knows what the card looks like before choosing. Pull from unused entities first, fall back to used entities. Scaling cards down to 60% of full size to fit better into the dialog. Using card config array instead of the string array of cards before.
Type of change
Additional information
Checklist