GUI editor for conditional card #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsarnett
reviewed
Mar 3, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Mar 3, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Mar 3, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Mar 3, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Mar 3, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Mar 3, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
thomasloven
force-pushed
the
conditional-editor
branch
3 times, most recently
from
c55490c
to
3b092d0
Compare
zsarnett
reviewed
Mar 4, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Mar 4, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Mar 4, 2020
zsarnett
reviewed
Mar 4, 2020
| "card": "Card", | ||
| "state_equal": "State is equal to", | ||
| "state_not_equal": "State is not equal to", | ||
| "current_state": "current", |
There was a problem hiding this comment.
Suggested change
| "current_state": "current", | |
| "current_state": "Current", |
should this be capitalized?
There was a problem hiding this comment.
I'm not sure. It's the "current" in State (current: 'on')...
thomasloven
force-pushed
the
conditional-editor
branch
2 times, most recently
from
87a62e0
to
fb8d6b6
Compare
9 tasks
bramkragten
reviewed
Mar 5, 2020
src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts
Outdated
Show resolved
Hide resolved
bramkragten
approved these changes
Mar 5, 2020
thomasloven
force-pushed
the
conditional-editor
branch
from
fb8d6b6
to
8d2981f
Compare
|
I'm getting really good at rebasing because of this PR... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: