Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Card: Adds Cursor: Pointer to Progress Bar #5091

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Mar 7, 2020

Proposed change

Cursor on Progress

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett changed the title Adds Cursor: Pointer to Progress Bar Media Card: Adds Cursor: Pointer to Progress Bar Mar 7, 2020
@@ -317,7 +317,13 @@ export class HuiMediaControlCard extends LitElement implements LovelaceCard {
.value="${getCurrentProgress(stateObj)}"
class="progress"
style="--paper-progress-active-color: ${this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use style=${styleMap({…}) instead of raw style.

@balloob balloob merged commit 5651a61 into home-assistant:dev Mar 9, 2020
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants