Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix area dialog too wide #5136

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Fix area dialog too wide #5136

merged 2 commits into from
Mar 12, 2020

Conversation

bramkragten
Copy link
Member

Fixes #5133

@bramkragten bramkragten changed the title Fix area dialog to wide Fix area dialog too wide Mar 11, 2020
balloob
balloob reviewed Mar 11, 2020
View reviewed changes
src/panels/config/areas/dialog-area-registry-detail.ts Outdated
@@ -142,8 +142,10 @@ class DialogAreaDetail extends LitElement {
return [
haStyleDialog,
css`
ha-paper-dialog {
min-width: 400px;
@media all and (min-width: 450px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this become a shared style ?

@balloob balloob merged commit d83b308 into dev Mar 12, 2020
@balloob balloob deleted the area-dialog-to-wide branch March 12, 2020 00:10
@bramkragten bramkragten added this to the 0.107 milestone Mar 12, 2020
@bramkragten bramkragten mentioned this pull request Mar 12, 2020
Merged
@lock lock bot locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
0.107
Development

Successfully merging this pull request may close these issues.

Create/update dialog button too far right, not responsive
3 participants
@bramkragten @balloob @homeassistant