Fix brightness_pct in light device turn_on action #5201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When creating a device automation in the frontend, the frontend UI, that turns on a light, and sets a brightness; The
brightness
andbrightness_pct
properties are mixed up.The UI input allows a user to select a value using a slider that reaches from 0-100, while the
brightness
property is used, which has a range from 0-255.2 way to fix this:
From a user UI perspective, the percentage makes more sense, so I opted to the latter.
PS: I have no clue how the translation works on our frontend and how to make this nicely translated (although I have the feeling this piece isn't translated at all?). Whatever the case, currently it shows
brightness_pct
in the interface, which is, of course, not that nice.PR on the core repository addressing this: home-assistant/core#32787
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: