Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hass.io panel for older version #5365

Merged
merged 2 commits into from Mar 30, 2020
Merged

Fix hass.io panel for older version #5365

merged 2 commits into from Mar 30, 2020

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Mar 30, 2020

Breaking change

Proposed change

Fix: #5363

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how we used the version in the supervisor panel before, if it should now be using hass.connection.haVersion we can look at that some other time.
But for now, I'll use my power to approve this.
I have tested the changes here on 0.106.4, and the panel now works on older core versions.

@ludeeus ludeeus merged commit ddb525f into dev Mar 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-hassio-panel-oldv branch March 30, 2020 09:39
@bramkragten bramkragten mentioned this pull request Mar 30, 2020
@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: new supervisor version not showing addons available or installed ones
3 participants