Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manfiests to render doc urls #5549

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Use manfiests to render doc urls #5549

merged 2 commits into from
Apr 15, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 15, 2020

Breaking change

Proposed change

Leverages home-assistant/core#34262 to load the documentation url from the integration manifests so we support custom components. Also updated our system log to be able to detect if an issue was logged by a custom component.

Also use names of integrations in the integration overview.

image

Closes #4929

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@TheZoker
Copy link
Contributor

Closes: #4929

@balloob balloob merged commit 66f33ad into dev Apr 15, 2020
@balloob balloob deleted the use-manifests branch April 15, 2020 20:36
@frenck
Copy link
Member

frenck commented Apr 15, 2020

Nice! 👍

@lock lock bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrations list documentation & issue link
5 participants