Ask specific translations #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
bramkragten
reviewed
Apr 17, 2020
bramkragten
reviewed
Apr 17, 2020
balloob
force-pushed
the
ask-specific-translations
branch
from
1dffabe
to
4745072
Compare
20 tasks
balloob
commented
Apr 18, 2020
| @@ -70,6 +70,7 @@ const createWebpackConfig = ({ | |||
| __BUILD__: JSON.stringify(latestBuild ? "latest" : "es5"), | |||
| __VERSION__: JSON.stringify(version), | |||
| __DEMO__: false, | |||
| __BACKWARDS_COMPAT__: false, | |||
There was a problem hiding this comment.
This new constant allows us to add some code paths to remain backwards compatibility. This path will be removed if backwards compat is turned off.
Currently only Cast will have this turned on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Update the frontend to only request the translations that it needs, instead of loading all translations of all possible integrations that will be encountered.
Requires home-assistant/core#34329
Also adds icons to onboarding
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: