Cleanup and new repository management for add-on store #5750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice in future PR to show if / how many advances addons are hidden in the missing message. |
bramkragten
reviewed
May 6, 2020
| import { HomeAssistant, Route } from "../../../src/types"; | ||
| import "../components/hassio-search-input"; | ||
| import "../../../src/common/search/search-input"; |
bramkragten
reviewed
May 6, 2020
src/common/search/search-input.ts
Outdated
| @@ -47,14 +50,18 @@ class SearchInput extends LitElement { | |||
| @value-changed=${this._filterInputChanged} | |||
| .noLabelFloat=${this.noLabelFloat} | |||
| > | |||
| <ha-icon icon="hass:magnify" slot="prefix" class="prefix"></ha-icon> | |||
| <ha-icon | |||
| icon="${this.hassio ? "hassio" : "hass"}:magnify" | |||
There was a problem hiding this comment.
Noooooooooo, I just learned I should do it this way.... 🤣
bramkragten
reviewed
May 6, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
May 7, 2020
bramkragten
reviewed
May 7, 2020
bramkragten
approved these changes
May 7, 2020
bramkragten
reviewed
May 7, 2020
src/resources/styles.ts
Outdated
| @@ -227,7 +227,7 @@ export const haStyleDialog = css` | |||
| --mdc-dialog-max-width: 600px; | |||
| --mdc-dialog-heading-ink-color: var(--primary-text-color); | |||
| --mdc-dialog-content-ink-color: var(--primary-text-color); | |||
| --mdc-theme-surface: var(--primary-background-color); | |||
| --mdc-theme-surface: var(--paper-card-background-color); | |||
There was a problem hiding this comment.
No need to put that in here, it is already derived in styles.ts
There was a problem hiding this comment.
I see, so I should fix it there instead then, it currently points to --card-background-color
Which results in:
There was a problem hiding this comment.
it's probably the theme I'm using that is incomplete, I'll remove it.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: