Fix generated Lovelace translating domain names #5803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
With the introduction of partial loaded translations, we now don't have access to the translations for domain names when generating Lovelace.
This is a problem because in Lovelace we group entities without an area in cards by their domain and use the translated title as the card title.
The fix is not easy, because when we load translations the updated
hass
object still has to propagate from the root element to where we are calling the function.So this PR implements one proposal to fix this: return the updated
hass
from thehass.loadBackendTranslations
function.I don't like this fix.
Alternative that Bram thought of: allow localizing at the root via an event. That won't work in this case as we pass the
localize
function to generate Lovelace.Alternative ideas:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: