Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate cards only on config change #5839

Merged
merged 2 commits into from
May 12, 2020
Merged

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented May 12, 2020

Proposed change

We would recreate the entire view on a change of width (like expanding the side menu) and switching edit mode.

We now only recalculate the columns without recreating the cards, for edit mode we wrap the existing cards with card-options instead of recreating the card.

With a lot of cards, and cards that fetch a lot of data on creation like history, this will make a big difference.

Before:
before

After:
after

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genius.

@balloob balloob merged commit 1b2841e into dev May 12, 2020
@balloob balloob deleted the recreate-cards-only-on-config-change branch May 12, 2020 18:09
@bramkragten bramkragten mentioned this pull request May 12, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants