Use comlink in workers #5915
Merged
Use comlink in workers #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
commented
May 17, 2020
| export const filterSortData = memoizeOne( | ||
| async ( | ||
| data: DataTableRowData[], | ||
| columns: DataTableColumnContainer, |
There was a problem hiding this comment.
This type was wrong, I replaced that with type SortableColumnContainer which I extracted from HaDataTable["_sortColumns"]
balloob
commented
May 17, 2020
| return filterData(data, columns, filter.toUpperCase()); | ||
| } | ||
| ); | ||
| const filterSortData = ( |
There was a problem hiding this comment.
I've removed all the memoization because of the copying.
balloob
commented
May 17, 2020
Comment on lines
+15
to
+25
| if (!worker) { | ||
| worker = wrap(new Worker("./sort_filter_worker", { type: "module" })); | ||
| } | ||
|
|
||
| return await worker.filterSortData( | ||
| data, | ||
| columns, | ||
| filter, | ||
| direction, | ||
| sortColumn | ||
| ); |
There was a problem hiding this comment.
To disable the built-in worker and use the API directly:
const workerAPI = await import("./sort_filter_worker");
return workerAPI.api.filterSortData(…)
bramkragten
approved these changes
May 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This migrates our two worker scripts to use
new Worker(…)and useworker-plugininstead ofworkerize-loaderto automatically move this worker script into a chunk. Workerize did two things: move script + dependencies into a chunk and create an async API for it.With worker-plugin + comlink we get the same experience except it's in two parts.
To help see what is going on, I have also extracted the code that interacts with the worker into standalone functions.
However, there is a downside to
comlink: it requires ES proxies.We have two options:
This PR implements the 1st option as it keeps our code more consistent. Easier to test.
Also, I saw that memoizeOne was used in the web worker for sorting/filtering. However, when data is copied from the UI thread to a worker thread, it's… copied :) So it can never hit the memoize fast-path of being equal to the last passed in data.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: