Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused deps #5916

Merged
merged 3 commits into from
May 18, 2020
Merged

Remove unused deps #5916

merged 3 commits into from
May 18, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented May 18, 2020

Breaking change

Proposed change

Remove some unused dependencies. Found by running npx depcheck.

Some of them are not actually removed from yarn.lock as some of our existing deps rely on them.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

"node-vibrant": "^3.1.5",
"regenerator-runtime": "^0.13.2",
"resize-observer": "^1.0.0",
"roboto-fontface": "^0.10.0",
"superstruct": "^0.6.1",
"tslib": "^1.10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this, "importHelpers": true, should also be removed from tsconfig? I guess it doesn't really matter because babel does our typescript work anyway...

@bramkragten bramkragten merged commit c37a691 into dev May 18, 2020
@bramkragten bramkragten deleted the remove-unused-deps branch May 18, 2020 21:10
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants