Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update invalid links in README.md #5926

Merged
merged 3 commits into from
May 19, 2020
Merged

Update invalid links in README.md #5926

merged 3 commits into from
May 19, 2020

Conversation

JeffResc
Copy link
Contributor

Proposed change

This updates the links to the frontend development page in the README file.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

N/A

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The developers' website doesn't use .html extension anymore.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
JeffResc and others added 2 commits May 19, 2020 03:38
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@JeffResc
Copy link
Contributor Author

I used those to keep consistency as I saw many links using .html, my apologies, I’ll exclude that from now on

@JeffResc JeffResc requested a review from frenck May 19, 2020 07:39
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for updating @JeffResc

@frenck frenck merged commit 61bd536 into home-assistant:dev May 19, 2020
@JeffResc JeffResc deleted the JeffResc-patch-1 branch May 19, 2020 07:55
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants