Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload #6062

Merged
merged 5 commits into from May 27, 2020
Merged

Preload #6062

merged 5 commits into from May 27, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented May 27, 2020

Breaking change

Proposed change

Was doing some performance profiling and I realized that our type=module loads the imports in a waterfall!

image

Now that's not cool! This PR adds app.js also as a preload tag so it is fetched as soon as possible.

image

I've also made the Roboto preloads conditional, it will only load if it's not Android, because we know for sure that Roboto is available there.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit aa9a354 into dev May 27, 2020
@balloob balloob deleted the preload branch May 27, 2020 19:54
@bramkragten bramkragten mentioned this pull request Jun 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants