Handle starting the frontend before finished loading integrations #6068

bramkragten · 2020-05-28T14:09:18Z

Proposed change

For home-assistant/core#36093

Needs home-assistant/home-assistant-js-websocket#117

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

src/state/disconnect-toast-mixin.ts

src/layouts/partial-panel-resolver.ts

src/panels/lovelace/common/generate-lovelace-config.ts

src/state/connection-mixin.ts

src/translations/en.json

bdraco · 2020-05-28T21:23:43Z

Looking good, code is now catching the start

Co-authored-by: J. Nick Koston <nick@koston.org>

balloob · 2020-05-28T23:34:56Z

src/panels/lovelace/cards/hui-button-card.ts

+        <hui-warning>
+          ${createEntityNotFoundWarning(this.hass, this._config.entity)}
+        </hui-warning>


Why actually expect caller to still wrap it in hui-warning and not just return a template from createEntityNotFoundWarning ?

balloob · 2020-05-28T23:54:44Z

I wonder if we can split the backend PR to already add state, so we can unblock this PR?

bdraco · 2020-05-29T01:41:01Z

I wonder if we can split the backend PR to already add state, so we can unblock this PR?

If I delete

    startup_listeners.append(
        hass.bus.async_listen(EVENT_COMPONENT_LOADED, async_wait_frontend_load)
    )

from the backend PR, it should be mergeable asis. Then we can add it back in later when supervisor is ready.

When integrations configured via the UI block startup or fail to start, the webserver can remain offline which make it is impossible to recover without manually changing files in .storage since the UI is not available. This change is the foundation that part 2 will build on and enable a listener to start the webserver when the frontend is finished loading. Frontend Changes (home-assistant/frontend#6068)

* Part 1 of 2 (no breaking changes in part 1). When integrations configured via the UI block startup or fail to start, the webserver can remain offline which make it is impossible to recover without manually changing files in .storage since the UI is not available. This change is the foundation that part 2 will build on and enable a listener to start the webserver when the frontend is finished loading. Frontend Changes (home-assistant/frontend#6068) * Address review comments * bump timeout to 1800s, adjust comment * bump timeout to 4h * remove timeout failsafe * and the test

When integrations configured via the UI block startup or fail to start, the webserver can remain offline which make it is impossible to recover without manually changing files in .storage since the UI is not available. This change is the foundation that part 2 will build on and enable a listener to start the webserver when the frontend is finished loading. Frontend Changes (home-assistant/frontend#6068)

* Part 1 of 2 (no breaking changes in part 1). When integrations configured via the UI block startup or fail to start, the webserver can remain offline which make it is impossible to recover without manually changing files in .storage since the UI is not available. This change is the foundation that part 2 will build on and enable a listener to start the webserver when the frontend is finished loading. Frontend Changes (home-assistant/frontend#6068) * Part 1 of 2 (no breaking changes in part 1). When integrations configured via the UI block startup or fail to start, the webserver can remain offline which make it is impossible to recover without manually changing files in .storage since the UI is not available. This change is the foundation that part 2 will build on and enable a listener to start the webserver when the frontend is finished loading. Frontend Changes (home-assistant/frontend#6068) * Part 2 of 2 (breaking changes in part 2). When integrations configured via the UI block startup or fail to start, the webserver can remain offline which make it is impossible to recover without manually changing files in .storage since the UI is not available. This change is the foundation that part 2 will build on and enable a listener to start the webserver when the frontend is finished loading. * bump timeout to 1800s, adjust comment * bump timeout to 1800s, adjust comment * bump timeout to 4h * bump timeout to 4h * remove timeout failsafe * remove timeout failsafe * and the test * and the test * find the test that needs mocking * find the test that needs mocking * Revert "find the test that needs mocking" This reverts commit 064e7787a8e9bc65df965530726fa1c41f8bcd36. * Revert "find the test that needs mocking" This reverts commit 064e7787a8e9bc65df965530726fa1c41f8bcd36. * fix the one that was missed due to the conflict

WIP

c1f5bb2

homeassistant added the cla-signed label May 28, 2020

bramkragten changed the title ~~WIP handle starting the frontend before finished loading integrations~~ Handle starting the frontend before finished loading integrations May 28, 2020

bdraco reviewed May 28, 2020

View reviewed changes

src/state/disconnect-toast-mixin.ts Outdated Show resolved Hide resolved

bramkragten added 3 commits May 28, 2020 16:12

Fire connected before started

b86aee7

Translate toasts + typo

01cdc56

Change entity unavailble warning during startup

b5064f7

This was referenced May 28, 2020

Ensure frontend is available if integrations fail to start - Part 1 of 2 home-assistant/core#36093

Merged

Refresh frontend on start event #6042

Closed

balloob reviewed May 28, 2020

View reviewed changes

src/layouts/partial-panel-resolver.ts Outdated Show resolved Hide resolved

balloob reviewed May 28, 2020

View reviewed changes

src/layouts/partial-panel-resolver.ts Outdated Show resolved Hide resolved

balloob reviewed May 28, 2020

View reviewed changes

src/panels/lovelace/common/generate-lovelace-config.ts Show resolved Hide resolved

balloob reviewed May 28, 2020

View reviewed changes

src/state/connection-mixin.ts Show resolved Hide resolved

balloob reviewed May 28, 2020

View reviewed changes

src/state/connection-mixin.ts Outdated Show resolved Hide resolved

bramkragten added 5 commits May 28, 2020 20:33

Comments

8579b76

Update disconnect-toast-mixin.ts

35b8cd8

Move generated refresh logic to starting card

f804ef2

Bump home-assistant-js-websocket

ae3723d

lint

ceccf8b

bramkragten marked this pull request as ready for review May 28, 2020 20:53

bramkragten added 2 commits May 28, 2020 23:06

Adjust states

5088d16

Catch when starting and running are fire around the same time

48cc98f

bdraco reviewed May 28, 2020

View reviewed changes

src/translations/en.json Outdated Show resolved Hide resolved

Update src/translations/en.json

d0e1932

Co-authored-by: J. Nick Koston <nick@koston.org>

balloob reviewed May 28, 2020

View reviewed changes

balloob approved these changes May 28, 2020

View reviewed changes

balloob merged commit d0a53d1 into dev May 29, 2020

balloob deleted the start-frontend-sooner branch May 29, 2020 04:09

This was referenced May 29, 2020

Make the frontend available sooner (Part 2 of 2) home-assistant/core#36264

Merged

Make the frontend available sooner (Part 1 of 2) home-assistant/core#36263

Merged

bramkragten mentioned this pull request Jun 3, 2020

20200603.0 #6093

Merged

github-actions bot locked and limited conversation to collaborators Jul 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle starting the frontend before finished loading integrations #6068

Handle starting the frontend before finished loading integrations #6068

bramkragten commented May 28, 2020 •

edited

bdraco commented May 28, 2020

balloob May 28, 2020

balloob commented May 28, 2020

bdraco commented May 29, 2020

Handle starting the frontend before finished loading integrations #6068

Handle starting the frontend before finished loading integrations #6068

Conversation

bramkragten commented May 28, 2020 • edited

Proposed change

Type of change

Example configuration

Additional information

Checklist

bdraco commented May 28, 2020

balloob May 28, 2020

Choose a reason for hiding this comment

balloob commented May 28, 2020

bdraco commented May 29, 2020

bramkragten commented May 28, 2020 •

edited