Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Jinja directives to own script block #6166

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 14, 2020

Breaking change

Proposed change

Also makes sure we only load the extra ES modules when the user is also loading the latest version of the frontend.

Move Jinja directives to their own script block so we can minimize the rest of the JS.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 8c0c059 into dev Jun 15, 2020
@bramkragten bramkragten deleted the jinja-own-script-block branch June 15, 2020 14:19
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants