Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip disconnect of custom panels and iframe panels #6248

Merged
merged 1 commit into from Jun 26, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 26, 2020

Breaking change

Proposed change

Skip the disconnect of panels that leverage iframes when idle.

Avoid disconnecting:

  • iFrame panel
  • custom panel that is rendered in an iFrame

This will avoid disconnecting ingress panels too, as they are custom panels embedded in an iframe.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus
Copy link
Member

ludeeus commented Jun 26, 2020

The section in the releasenotes should probably be adjusted for this https://rc.home-assistant.io/blog/2020/06/24/release-112/#automatically-disconnect-if-a-tab-has-been-hidden-for-5-minutes

So it states that it does not apply to iframes, or custom_panels that embeds as an iframe.

@balloob
Copy link
Member Author

balloob commented Jun 26, 2020

Good idea, will open a PR.

@balloob
Copy link
Member Author

balloob commented Jun 26, 2020

Oh actually, that is about disconnecting the Websocket connection. Not disconnecting the panel from the DOM.

@balloob balloob merged commit e4d55e6 into dev Jun 26, 2020
@balloob balloob deleted the skip-disconnect-custom-iframe branch June 26, 2020 19:53
@balloob balloob mentioned this pull request Jun 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants