Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for constant in ha-form #6324

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Add support for constant in ha-form #6324

merged 3 commits into from
Jul 7, 2020

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Jul 3, 2020

Proposed change

image

Backend PR: home-assistant/core#37241

Closes: #6284

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob
Copy link
Member

balloob commented Jul 5, 2020

When a form is loaded with constant values, we should make sure we add those to the values that we're going to send to the server.

bramkragten and others added 2 commits July 6, 2020 09:41
@balloob
Copy link
Member

balloob commented Jul 7, 2020

Backend merged

@bramkragten bramkragten merged commit 0c58c35 into dev Jul 7, 2020
@bramkragten bramkragten deleted the ha-form-constant branch July 7, 2020 07:23
@bramkragten bramkragten mentioned this pull request Jul 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support constants in ha-form
3 participants