RTL fixes - cloud section, ha-formfield, some missing + (mwc-fab) #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Jul 6, 2020
bramkragten
reviewed
Jul 6, 2020
bramkragten
reviewed
Jul 6, 2020
| .label=${this.hass!.localize( | ||
| "ui.panel.config.cloud.google.disable_2FA" | ||
| )} | ||
| .dir="${computeRTLDirection(this.hass!)}" |
There was a problem hiding this comment.
If we use it multiple times in one element, we can do this on top of render:
const dir = computeRTLDirection(this.hass!);and use that
Suggested change
| .dir="${computeRTLDirection(this.hass!)}" | |
| .dir=${dir} |
bramkragten
reviewed
Jul 6, 2020
| .label=${this.hass!.localize( | ||
| "ui.dialogs.mqtt_device_debug_info.deserialize" | ||
| )} | ||
| .dir="${computeRTLDirection(this.hass)}" |
There was a problem hiding this comment.
Suggested change
| .dir="${computeRTLDirection(this.hass)}" | |
| .dir=${computeRTLDirection(this.hass)} |
|
Also refactored a few other places with duplicate RTL calc |
bramkragten
approved these changes
Jul 6, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Fixes RTL issues in cloud section + missing + sign to add zones, etc'...
Fixes cross system ha-formfield RTL support.
Tested in both English and Hebrew.
More to come...
Bugfix (non-breaking change which fixes an issue)
Code quality improvements to existing code or addition of tests
The code change is tested and works locally.
There is no commented out code in this PR.