Migrate more-info-dialog to mwc and Lit #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
| const domain = computeDomain(entityId); | ||
|
|
||
| return html` | ||
| <ha-dialog open @closed=${this._close} .heading=${true} hideActions> |
There was a problem hiding this comment.
Can we make heading a boolean attribute so we can just make this
Suggested change
| <ha-dialog open @closed=${this._close} .heading=${true} hideActions> | |
| <ha-dialog open @closed=${this._close} heading hideActions> |
I think we might also want to rename it to something that better describes what it does. renderHeading ?
There was a problem hiding this comment.
it is a hack, it is from mwc-dialog it should be a string they only call renderHeading when heading is truthy, but we want to use the slot...
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
| <ha-svg-icon .path=${mdiClose}></ha-svg-icon> | ||
| </mwc-icon-button> | ||
| <div class="main-title" main-title @click=${this._enlarge}> | ||
| ${stateObj ? computeStateName(stateObj) : ""} |
There was a problem hiding this comment.
Should we even render all of this when there is no stateObj ? I think we only did that in Polymer because it was so difficult to not do it.
There was a problem hiding this comment.
Should we no render the dialog at all?
There was a problem hiding this comment.
Nope. No state object means we hide the dialog.
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
approved these changes
Jul 7, 2020
balloob
reviewed
Jul 7, 2020
balloob
approved these changes
Jul 7, 2020
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrates the more-info dialog to mwc elements and Lit.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: