Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close dialogs on history back #6354

Merged
merged 10 commits into from
Jul 12, 2020
Merged

Close dialogs on history back #6354

merged 10 commits into from
Jul 12, 2020

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Jul 9, 2020

Proposed change

A start on closing dialogs on history back like we already did for the more info dialog.

Extra bonus, going forward in the browser history will reopen the dialog (if possible).
If you open a dialog from another dialog, going back from the second dialog will reopen the first dialog.

Dialogs should implement a closeDialog function, that should take care of closing the dialog and then fire the event dialog-closed.

You can prevent a dialog from closing on back by returning false from closeDialog (for a dialog that should not be closed without a specific action of that doesn't have a cancel/close button).

Dialogs that don't implement closeDialog yet, won't be closed on back, and the history will be a little screwed up (first back will not do anything, second back will give the current behavior).
So we should add closeDialog to all dialogs 馃槃

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten force-pushed the close-dialogs-on-history-back branch from 7878bb4 to 5d40824 Compare July 10, 2020 08:59
@bramkragten bramkragten merged commit 3d32e63 into dev Jul 12, 2020
@bramkragten bramkragten deleted the close-dialogs-on-history-back branch July 12, 2020 20:19
@bramkragten bramkragten mentioned this pull request Jul 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants