-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close dialogs on history back #6354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 10, 2020
balloob
reviewed
Jul 10, 2020
7878bb4
to
5d40824
Compare
balloob
reviewed
Jul 10, 2020
balloob
approved these changes
Jul 10, 2020
3 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
A start on closing dialogs on history back like we already did for the more info dialog.
Extra bonus, going forward in the browser history will reopen the dialog (if possible).
If you open a dialog from another dialog, going back from the second dialog will reopen the first dialog.
Dialogs should implement a
closeDialog
function, that should take care of closing the dialog and then fire the eventdialog-closed
.You can prevent a dialog from closing on back by returning false from
closeDialog
(for a dialog that should not be closed without a specific action of that doesn't have a cancel/close button).Dialogs that don't implement
closeDialog
yet, won't be closed on back, and the history will be a little screwed up (first back will not do anything, second back will give the current behavior).So we should add
closeDialog
to all dialogs 馃槃Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: