Fix graph mouse over in more info dialog #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 12, 2020
| @@ -243,6 +243,10 @@ export class MoreInfoDialog extends LitElement { | |||
| return [ | |||
| haStyleDialog, | |||
| css` | |||
| ha-dialog { | |||
| --dialog-content-position: static; | |||
There was a problem hiding this comment.
Are we sure about this? Doesn't this mean that if the dialog is taller than the window, we won't be able to scroll ?
There was a problem hiding this comment.
I tested it and it seemed fine, but yeah they probably had a reason to make it relative...
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Before:
After:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: