Entity dialogs: Remove paper element and align dialog header style #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 13, 2020
src/components/ha-header-bar.ts
Outdated
| @property({ type: Boolean }) centerTitle = false; | ||
|
|
||
| protected render() { | ||
| let title = html`<span class="mdc-top-app-bar__title"> |
There was a problem hiding this comment.
Let's make this a ternary statement.
There was a problem hiding this comment.
the second one uses the first one.
There was a problem hiding this comment.
But I ended up not using it because it doesn't work well, so might as well remove it...
balloob
reviewed
Jul 13, 2020
| unsafeCSS(topAppBarStyles), | ||
| css` | ||
| .mdc-top-app-bar { | ||
| position: static; |
There was a problem hiding this comment.
Are we sure we want to put this in the element itself and not have the parent decide on this?
There was a problem hiding this comment.
This could be used outside of dialogs, no?
There was a problem hiding this comment.
If you would want to use on the top scope you should use <mwc-top-app-bar>
balloob
approved these changes
Jul 13, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Align the header style on desktop more with default material dialog styles as we use throughout the app.
Replace
paper-tabsandapp-toolbarwithLitElementversions.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: