Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make menu's work with keyboard #6421

Merged
merged 1 commit into from Jul 17, 2020
Merged

Make menu's work with keyboard #6421

merged 1 commit into from Jul 17, 2020

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Jul 17, 2020

Proposed change

Menu's didn't work with keyboard events, now it does.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@@ -302,6 +302,10 @@ export class HuiCardEditor extends LitElement {
.yaml-editor {
padding: 8px 0px;
}
.error,
.warning {
word-break: break-word;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #6420 right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

@ludeeus ludeeus merged commit 92915ed into dev Jul 17, 2020
@ludeeus ludeeus deleted the menu-keyboard-action branch July 17, 2020 18:31
@bramkragten bramkragten mentioned this pull request Aug 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning text makes UI editor unusable
3 participants