New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce dark mode and primary color picker #6430
Conversation
Playing around with this. I don't know how often it would be used but something I just tried to find was a reset button. To reset the Primary and Accent colors to default. Not this PR stuff just thinking out loud |
Just clear your local storage, or log out, or use incognito mode, or I'll add a button for that. |
></paper-input> | ||
<paper-input | ||
.value=${this.hass!.selectedTheme?.accentColor || "#ff9800"} | ||
type="color" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
dark = true; | ||
break; | ||
} | ||
fireEvent(this, "settheme", { dark }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So one thing that we're going to get feedback on is that people will want to share their theme with other users. I guess we can facilitate that in a future PR (probably needs support in frontend integration)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just 2 colors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but the other people in my house won't take the time to configure a theme, but maybe my Lovelace setup requires that. I guess we can do that in backend selected still 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you mean users in your HA, I was thinking users as the community. I understand it now :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could add these vars to the set theme service call, and add a button in the frontend to set the current settings as default.
We should make sure these settings are stored on the backend btw, as it now doesn't survive a restart?
No color library that is small? Bram: "Screw it. I'll make my own library, with blackjack and hookers" 😄 (Futurama Reference for anyone who doesn't know) |
It is more mix and match ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bramkragten curious - is this depreciating using hsl in themes? Just need to know if I need to start working on updating my theme :-) thanks for bringing dark mode up to major league status!
No, nothing will change for existing themes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug console log
Proposed change
home-assistant/core#37967
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: