Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for safe area insets #6473

Merged
merged 5 commits into from Jul 30, 2020
Merged

Add support for safe area insets #6473

merged 5 commits into from Jul 30, 2020

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Jul 27, 2020

Proposed change

Mainly checked on iPhone now, might need some further tweaks.

Closes #6148

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zacwest
Copy link
Member

zacwest commented Jul 28, 2020

This is a huge improvement, thank you so much!

Here are a few things I've noticed playing with it, grouped by theme. Overall feels really good though.

  • Confirmation on integration settings: the 'update' button is underneath the safe area, but also clipped off the screen. This also happens for the editing of e.g. device or entity settings.
  • Card configuration is similar, the action buttons are underneath the home indicator. This is also the case when adding a new card, editing a scene.
  • Delete confirmation and editing e.g. the name of an integration like Shopping List, logout confirmation.
  • TOTP Setup: not sure if there is one, but it also seems like the cancel button may be hidden somewhere, too.
  • Page bottoms in Dashboards, Profile: feels like the bottom of the container could use some padding, since the 'create token' button is outside the safe area, and the dashboard contents are also bleeding out of the safe area.
  • Profile button in hamburger menu: could this be bumped up at all? It's 'dangerously'-feeling close to the bottom of the menu.

@bramkragten
Copy link
Member Author

Think I addressed it all, did you just check portrait or also landscape?

@zacwest
Copy link
Member

zacwest commented Jul 28, 2020

I did--couldn't find anything landscape-exclusive, it feels a lot better now that the bars are extending to the full-bleed edges. Ran the latest, a couple more things, but largely perfect!

@bramkragten
Copy link
Member Author

Done!

@bramkragten bramkragten merged commit ca4f573 into dev Jul 30, 2020
@bramkragten bramkragten deleted the safe-area-inset branch July 30, 2020 16:27
@bramkragten bramkragten mentioned this pull request Aug 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS app tweaks needed for FABs and tab bars
4 participants