Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gauge when safari is zoomed #6492

Merged
merged 2 commits into from Aug 3, 2020
Merged

Fix gauge when safari is zoomed #6492

merged 2 commits into from Aug 3, 2020

Conversation

bramkragten
Copy link
Member

Proposed change

It's kinda dirty, and it does browser detection... but what works in Safari breaks things in Firefox... Chrome doesn't care, everything works in Chrome...

Animation between values won't work anymore for Safari, only the initial animation.

Fixes #6467

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett
Copy link
Contributor

This is atrocious... Like why safari

@fjufju
Copy link

fjufju commented Jul 31, 2020

If bug in safari maybe create issue in their repo? This is a hack workaround @bramkragten can You do this? Thank you.

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@bramkragten bramkragten merged commit 8fb62eb into dev Aug 3, 2020
@bramkragten bramkragten deleted the fix-gauge-safari branch August 3, 2020 14:32
@bramkragten bramkragten mentioned this pull request Aug 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gauge doesn’t show properly in Safari macOS
5 participants