Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes display issues with the new darkmode #6532

Merged
merged 9 commits into from Aug 6, 2020
Merged

Fixes display issues with the new darkmode #6532

merged 9 commits into from Aug 6, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Aug 5, 2020

Breaking change

Proposed change

fixes #6531

Forces white background and black "text" for the svg

image

fixes #6529

Uses a lighter color for the icon so it's easier to see

image

fixes #6528

Uses a lighter color for the lebal so it's easier to see

image

closes #5394

Set the backgrounds to dark in init (before loading) if dark is selected on the client

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus changed the title Fix issues with QR code for MFA Fixes display issues with the new darkmode Aug 5, 2020
@ludeeus ludeeus marked this pull request as ready for review August 5, 2020 22:30
@frenck frenck added this to the 0.114.0 milestone Aug 6, 2020
src/resources/styles.ts Outdated Show resolved Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
ludeeus and others added 2 commits August 6, 2020 14:39
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
src/resources/styles.ts Outdated Show resolved Hide resolved
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit 16b8b66 into dev Aug 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the darkmode-fixes branch August 6, 2020 15:51
@bdraco
Copy link
Member

bdraco commented Aug 6, 2020

@SeanPM5

Screen Shot 2020-08-06 at 10 57 34 AM

Here is the markdown we use for homekit. I'm not sure how we can set a background color here.

    message = (
        f"To set up {bridge_name} in the Home App, "
        f"scan the QR code or enter the following code:\n"
        f"### {pin}\n"
        f"![image](/api/homekit/pairingqr?{entry_id}-{pairing_secret})"
    )
    hass.components.persistent_notification.create(
        message, "HomeKit Bridge Setup", entry_id
    )

@bdraco
Copy link
Member

bdraco commented Aug 6, 2020

Fixed homekit here home-assistant/core#38609

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.