New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes display issues with the new darkmode #6532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludeeus
changed the title
Fix issues with QR code for MFA
Fixes display issues with the new darkmode
Aug 5, 2020
bramkragten
reviewed
Aug 6, 2020
bramkragten
reviewed
Aug 6, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
approved these changes
Aug 6, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Aug 6, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Here is the markdown we use for homekit. I'm not sure how we can set a background color here.
|
Fixed homekit here home-assistant/core#38609 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
fixes #6531
Forces white background and black "text" for the svg
fixes #6529
Uses a lighter color for the icon so it's easier to see
fixes #6528
Uses a lighter color for the lebal so it's easier to see
closes #5394
Set the backgrounds to dark in init (before loading) if dark is selected on the client
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: