Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color and overlap in close dialog header #6539

Merged
merged 2 commits into from Aug 6, 2020
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Aug 6, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Before

image

After

image

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added this to the 0.114.0 milestone Aug 6, 2020
@ludeeus
Copy link
Member Author

ludeeus commented Aug 6, 2020

You where right, it was that simple

@bramkragten bramkragten merged commit 69f4a61 into dev Aug 6, 2020
@bramkragten bramkragten deleted the dialog-close-header branch August 6, 2020 15:51
@bramkragten
Copy link
Member

I see you removed the overlap fix, was that intentional? I think that can still happen now?

@ludeeus
Copy link
Member Author

ludeeus commented Aug 6, 2020

Does not happen on this dialog at least anymore

@bramkragten
Copy link
Member

Yeah because the width was changed by the styles probably, but if the translation is longer it will?

@ludeeus
Copy link
Member Author

ludeeus commented Aug 6, 2020

YUP! :(

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping close button on Move card dialog heading 0.114.0b0
3 participants