-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag config panel #6601
Add tag config panel #6601
Conversation
src/panels/config/automation/trigger/types/ha-automation-trigger-tag.ts
Outdated
Show resolved
Hide resolved
"ui.panel.config.tags.detail.name" | ||
)}" | ||
.errorMessage="${this.hass!.localize( | ||
"ui.panel.config.tags.detail.required_error_msg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is name required ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes... with min length 1
return; | ||
} | ||
foundTag.last_scanned = ev.time_fired; | ||
this._tags = [...this._tags]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we copying it and not just requestUpdate ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of memoize
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: