Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default as fallback theme for older versions #6603

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Aug 12, 2020

Breaking change

Proposed change

Fall back to default_theme if no theme is selected (This is true for "Backend-selected")

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label Aug 12, 2020
@ludeeus ludeeus merged commit 77b25f5 into dev Aug 12, 2020
@ludeeus ludeeus deleted the supervisor-theme-legacy-backendselected branch August 12, 2020 13:40
@bramkragten bramkragten mentioned this pull request Aug 20, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

supervisor dashboard not honoring theme set
3 participants