-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play HLS with Exoplayer on Android #6606
Play HLS with Exoplayer on Android #6606
Conversation
011a375
to
8965da2
Compare
7e0be93
to
8f88ef8
Compare
I'm not familiar with ExoPlayer and the Android part, so can't really judge it, but not sure this is something we want to support... |
I think this is the easiest way to get H.265 playing in app. Otherwise Android users are SOL if they want to use H.265. If the client doesn't support it (another platform, browser, or app) it just reverts to the usual functionality. Adding this might seem excessive for just one additional bit of functionality on one component, but I think it's a pretty important function as many cameras are moving to H.265 and the codec affords a significant bandwidth reduction over H.264. |
a94fe84
to
a491ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 final comments. Rest looks good.
See also: home-assistant/core#38125 & home-assistant/android/pull/739
H.265 videos are not supported through Chromium or Webview on Android. We can work around this for Android by using Exoplayer which supports H.265 if the codecs are available on the device. This PR uses the externalApp interface to test whether Exoplayer is available from the config and uses the interface to send the requests to Exoplayer if available. I will open another PR on the Mobile App repository to implement the Exoplayer interface on the Android side.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: