Media More Info: Convert to Lit Element #6619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Aug 17, 2020
bramkragten
reviewed
Aug 17, 2020
bramkragten
reviewed
Aug 17, 2020
Comment on lines
355
to
364
| const services = this.hass.services.tts; | ||
| const serviceKeys = Object.keys(services).sort(); | ||
| let service: string | undefined; | ||
|
|
||
| for (let i = 0; i < serviceKeys.length; i++) { | ||
| if (serviceKeys[i].indexOf("_say") !== -1) { | ||
| service = serviceKeys[i]; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Ugh, this is so ugly, we should look into it sometime...
bramkragten
reviewed
Aug 17, 2020
zsarnett
commented
Aug 17, 2020
| const services = this.hass.services.tts; | ||
| const serviceKeys = Object.keys(services).sort(); | ||
|
|
||
| const service = serviceKeys.find((key) => key.indexOf("_say") !== -1); |
There was a problem hiding this comment.
@bramkragten This should be a bit better than the for loop I think. Still maybe not the best way
There was a problem hiding this comment.
the fact that we just pick the first one is wrong, to begin with... But yeah, this code is a lot better
There was a problem hiding this comment.
Yea... that's what I was thinking. We also sort them... but from the data, we are given from the service there doesn't seem to be a way to find the preferred one
bramkragten
approved these changes
Aug 17, 2020
Merged
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Convert to Lit
Type of change