Improve messaging of empty device info cards #6628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Aug 17, 2020
src/translations/en.json
Outdated
| @@ -1339,6 +1339,7 @@ | |||
| } | |||
| }, | |||
| "devices": { | |||
| "add_prompt": " have been added using this device yet. You can add one by clicking the + button above.", | |||
There was a problem hiding this comment.
We can't have half sentences in translations, because the word order in other languages might be different.
There was a problem hiding this comment.
You can use variables:
No {name} have been added using this device yet. You can add one by clicking the + button above.
bramkragten
approved these changes
Aug 17, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improves messaging on device info page for empty cards
Type of change
Additional information
Checklist