Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picture upload component #6646

Merged
merged 16 commits into from
Aug 19, 2020
Merged

Add picture upload component #6646

merged 16 commits into from
Aug 19, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Aug 18, 2020

Breaking change

Proposed change

Add a new picture upload component. Requires home-assistant/core#38969

To do:

  • styling
  • clear picture button
  • fire change event
  • Use it somewhere (person integration)
<ha-picture-upload .hass=${this.hass}></ha-picture-upload>

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

dragged: this._drag,
})}
>
<label for="input" slot="label">Picture</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lokalize?

@zsarnett
Copy link
Contributor

Should we set a minimum dimension on the crop?

@bramkragten
Copy link
Member

Should we set a minimum dimension on the crop?

I don't think we can do that in cropperjs, and not sure if that is needed...

@balloob balloob merged commit f928a8e into dev Aug 19, 2020
@balloob balloob deleted the picture-upload branch August 19, 2020 09:33
@bramkragten bramkragten mentioned this pull request Aug 20, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants