Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating history card + only update when entity changed #6647

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Aug 18, 2020

Proposed change

Fixes #5129

And only fetch history when the state of a shown entity is changed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@ludeeus ludeeus merged commit e2fd155 into dev Aug 24, 2020
@ludeeus ludeeus deleted the fix-history-card-updating branch August 24, 2020 15:03
@bramkragten bramkragten mentioned this pull request Aug 24, 2020
@manutoky
Copy link

Any chance that 0.115.2 reverted this fix? My history cards are not updating anymore after the HA update.

@Leapo
Copy link

Leapo commented Sep 24, 2020

Any chance that 0.115.2 reverted this fix? My history cards are not updating anymore after the HA update.

Seeing the same behavior here

@zsarnett
Copy link
Contributor

Please do not comment on old PRs. PLease create a new issue

@home-assistant home-assistant locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History Graph Card (history-graph) not updating until the page is manually refreshed
6 participants