Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify renaming entity ids #6668

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Clarify renaming entity ids #6668

merged 2 commits into from
Aug 21, 2020

Conversation

bramkragten
Copy link
Member

Proposed change

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick handling of this!!

src/translations/en.json Outdated Show resolved Hide resolved
@bramkragten
Copy link
Member Author

2 approvals and nobody spots the typo 😜

@ludeeus
Copy link
Member

ludeeus commented Aug 21, 2020

I even had to read over it 4 times with the change highlighted to see it :/

@dmulcahey
Copy link
Contributor

Lol I read it several times myself...

@bramkragten bramkragten merged commit 22210b7 into dev Aug 21, 2020
@bramkragten bramkragten deleted the clarify-rename-entities-dialog branch August 21, 2020 14:25
@bramkragten bramkragten mentioned this pull request Aug 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants