Convert dev tools template to Lit and store last used template #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Aug 21, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
ludeeus
reviewed
Aug 21, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
balloob
reviewed
Aug 21, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 21, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
zsarnett
reviewed
Aug 21, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
balloob
reviewed
Aug 22, 2020
| } else { | ||
| this._template = DEMO_TEMPLATE; | ||
| } | ||
| this._renderTemplate(); |
There was a problem hiding this comment.
Instead of rendering, why don't we just subscribe ? See subscribeRenderTemplate in data/ws-template.ts
There was a problem hiding this comment.
If we don't pass that entity id's, will that update on every state change?
There was a problem hiding this comment.
Random is nice like that 😛
ludeeus
reviewed
Aug 24, 2020
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
src/panels/developer-tools/template/developer-tools-template.ts
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: