Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media browser #6672

Merged
merged 25 commits into from
Aug 24, 2020
Merged

Media browser #6672

merged 25 commits into from
Aug 24, 2020

Conversation

zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Aug 21, 2020

Proposed change

6dba66c8bdcabcc9b3c7ad16e0ed1353

image

image

Type of change

  • New feature (thank you!)

Example configuration

<ha-media-player-browse
  .hass=${this.hass}
  entityId="media_player.plex_plex_web_chrome"
  action="pick"
  @media-picked=${(ev) => console.log(ev.detail)}
></ha-media-player-browse>

Additional information

Checklist

  • Add this to a dialog somewhere
  • Documentation added/updated for [www.home-assistant.io][docs-repository]

src/data/media-player.ts Outdated Show resolved Hide resolved
@bramkragten
Copy link
Member

So we don't actually have a place where we use this right now? Let's add it to the media player card to start with if the media player supports it.

${controls!.map(
(control) => html`
<ha-icon-button
action=${control.action}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add titles here too in a future PR

@zsarnett zsarnett merged commit 5fd8b5c into dev Aug 24, 2020
@zsarnett zsarnett deleted the media-browser branch August 24, 2020 14:31
@bramkragten bramkragten mentioned this pull request Aug 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants