Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic nodes list & node metadata to OZW config panel #6719

Merged
merged 16 commits into from
Sep 4, 2020
Merged

Add basic nodes list & node metadata to OZW config panel #6719

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
156dcaa
WIP: OZW config panel nodes list
cgarwood Aug 27, 2020
cc2e4e7
Comments
bramkragten Aug 29, 2020
c8ab8fb
Tweaks
cgarwood Aug 29, 2020
8e38a51
Cleanup
cgarwood Aug 29, 2020
34c2f4e
Update function declaration
cgarwood Aug 31, 2020
608140b
Tweak column sizes and add translations
cgarwood Aug 31, 2020
21765e2
Add basic node info to node dashboard page
cgarwood Aug 31, 2020
33ebdf6
Add click handler
cgarwood Aug 31, 2020
c8545e8
Simplify node-level routing
cgarwood Sep 3, 2020
a559579
Finish cleaning up routers
cgarwood Sep 3, 2020
f681268
Review comments
cgarwood Sep 3, 2020
bb25144
lint
cgarwood Sep 3, 2020
69b74ae
Update ozwInstance and nodeId handling
cgarwood Sep 4, 2020
f7ca57a
Guard for node not found
cgarwood Sep 4, 2020
11052d1
Improve handling of node not found errors
cgarwood Sep 4, 2020
547292c
Review comments
cgarwood Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/panels/config/integrations/integration-panels/ozw/ozw-network-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,14 @@ class OZWNetworkRouter extends HassRouterPage {
};

protected updatePageEl(el): void {
el.route = this.routeTail;
el.route = computeTail(this.routeTail);
el.hass = this.hass;
el.isWide = this.isWide;
el.narrow = this.narrow;
el.configEntryId = this._configEntry;
el.ozwInstance = this.ozwInstance;
if (this._currentPage === "node") {
const path = this.routeTail.path.split("/");
el.nodeId = path[1];
el.route = computeTail(this.routeTail);
el.nodeId = this.routeTail.path.split("/")[1];
}
}
}
Expand Down
10 changes: 6 additions & 4 deletions src/panels/config/integrations/integration-panels/ozw/ozw-node-dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,18 @@ class OZWNodeDashboard extends LitElement {

@property() public configEntryId?: string;

@property() public ozwInstance = 0;
@property() public ozwInstance?;

@property() public nodeId = 0;
@property() public nodeId?;

@internalProperty() private _node?: OZWDevice;

@internalProperty() private _metadata?: OZWDeviceMetaDataResponse;

protected firstUpdated() {
if (this.ozwInstance <= 0) {
if (!this.ozwInstance) {
navigate(this, "/config/ozw/dashboard", true);
} else if (this.nodeId <= 0) {
} else if (!this.nodeId) {
navigate(this, `/config/ozw/network/${this.ozwInstance}/nodes`, true);
} else if (this.hass) {
this._fetchData();
Expand Down Expand Up @@ -135,6 +135,8 @@ class OZWNodeDashboard extends LitElement {
}

private async _fetchData() {
if (!this.ozwInstance || !this.nodeId) return;
cgarwood marked this conversation as resolved.
Show resolved Hide resolved

this._node = await fetchOZWNodeStatus(
this.hass!,
this.ozwInstance,
Expand Down