Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hassio-addon-audio feedback #6731

Merged
merged 1 commit into from
Sep 3, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 13 additions & 5 deletions hassio/src/addon-view/config/hassio-addon-audio.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import { haStyle } from "../../../../src/resources/styles";
import { HomeAssistant } from "../../../../src/types";
import { suggestAddonRestart } from "../../dialogs/suggestAddonRestart";
import { hassioStyle } from "../../resources/hassio-style";
import "../../../../src/components/buttons/ha-progress-button";

@customElement("hassio-addon-audio")
class HassioAddonAudio extends LitElement {
Expand Down Expand Up @@ -91,7 +92,9 @@ class HassioAddonAudio extends LitElement {
</paper-dropdown-menu>
</div>
<div class="card-actions">
<mwc-button @click=${this._saveSettings}>Save</mwc-button>
<ha-progress-button @click=${this._saveSettings}>
Save
</ha-progress-button>
</div>
</ha-card>
`;
Expand Down Expand Up @@ -172,7 +175,10 @@ class HassioAddonAudio extends LitElement {
}
}

private async _saveSettings(): Promise<void> {
private async _saveSettings(ev: CustomEvent): Promise<void> {
const button = ev.target as any;
button.progress = true;

this._error = undefined;
const data: HassioAddonSetOptionParams = {
audio_input:
Expand All @@ -182,12 +188,14 @@ class HassioAddonAudio extends LitElement {
};
try {
await setHassioAddonOption(this.hass, this.addon.slug, data);
if (this.addon?.state === "started") {
await suggestAddonRestart(this, this.hass, this.addon);
}
} catch {
this._error = "Failed to set addon audio device";
}
if (!this._error && this.addon?.state === "started") {
await suggestAddonRestart(this, this.hass, this.addon);
}

button.progress = false;
}
}

Expand Down